[10.0] Add options to subscription swap #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
driesvints
approved these changes
Mar 19, 2019
|
This won't solve #550 because that should be done with the subscription builder instead. |
|
Thanks! |
|
This seems to have broken the build: https://travis-ci.org/laravel/cashier/builds/508282346?utm_medium=notification&utm_source=email The fact that builds don't run on PRs for this repo is a real PITA 🤦♂️ |
|
Ah, I know what's wrong. We'll need to update the coupon duration probably on our own Stripe test account. This is where #622 would come in handy... |
|
I can take a crack at #622 over the next couple days. |
|
Would be great. I'll try to provide feedback if you want. Hit me up on Discord if you have questions. |
|
In the meantime I'll try to get the test coupon fixed as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #580 - you can now pass in parameters when swapping a subscription, such as a coupon.
I believe this would also resolve #550, but I haven't tested it.
Pull request to the master branch.