Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Mark asStripe... methods internal #796

Closed
wants to merge 1 commit into from

Conversation

netpok
Copy link

@netpok netpok commented Oct 11, 2019

Based on this comment objects returned by the asStripe.. methods should not be considered part of the public api so it should be marked as internal to notify developers.

@netpok netpok force-pushed the internal-methods branch 2 times, most recently from dd7ac82 to 372bbca Compare October 11, 2019 09:01
@driesvints
Copy link
Member

Tbh, I don't exactly agree with this (see my comment linked above). If you're relying on functionality by the SDK then you need to add it to your composer.json file to make sure that if upstream changes are made to the used library that Composer will prevent you from upgrading to a version that your app doesn't supports.

@driesvints driesvints changed the title Mark asStripe... methods internal [10.x] Mark asStripe... methods internal Oct 11, 2019
@netpok
Copy link
Author

netpok commented Oct 11, 2019

In my opinion exposing the underlying object and exceptions makes it part of the public API.

The Semver FAQ entry is about packages used, but not part of the public API.
For example Cashier is using MoneyPHP to format the amount, but it is not exposed in any way.

@driesvints
Copy link
Member

@netpok that's a valid point. Let's see what Taylor thinks.

@taylorotwell
Copy link
Member

I don't consider them internal really. Sometimes you may need the underlying object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants