[10.x] Fix findInvoiceOrFail behavior #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the changes made to the constructor of the Invoice object recently, the subsequent findInvoiceOrFail method didn't throw the AccessDeniedHttpException anymore and instead threw the new Exception from the constructor. I've now fixed this method to properly throw the AccessDeniedHttpException again. I've also changed the Exception classes to two dedicated Exception classes which people can type-hint against.
driesvints
force-pushed
the
fix-find-invoice-or-fail
branch
from
b4bda86 to
3e60ab2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the changes made to the constructor of the Invoice object recently, the subsequent findInvoiceOrFail method didn't throw the AccessDeniedHttpException anymore and instead threw the new Exception from the constructor. I've now fixed this method to properly throw the AccessDeniedHttpException again.
I've also changed the Exception classes to two dedicated Exception classes which people can type-hint against.
Fixes #851