Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.x] Replace hardcoded strings with constants #981

Merged
merged 2 commits into from
Aug 10, 2020
Merged

[12.x] Replace hardcoded strings with constants #981

merged 2 commits into from
Aug 10, 2020

Conversation

sebdesign
Copy link
Contributor

Addresses #963

@driesvints
Copy link
Member

@sebdesign awesome. Thanks!

@driesvints driesvints changed the title Replace hardcoded strings with constants [12.x] Replace hardcoded strings with constants Aug 8, 2020
@driesvints
Copy link
Member

Note that tests are failing because they can only run properly on the main repo.

@taylorotwell taylorotwell merged commit 2ef4214 into laravel:12.x Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebdesign @driesvints @taylorotwell