[12.x] Added ability to confirm payments that require action #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@taylorotwell I'll review this when I get back on Monday. |
driesvints
changed the title
|
@mehrancodes @taylorotwell I'm gonna post pone this review for a bit until I've finished updating our libraries for Laravel 8. I'll check into this as soon as I can. |
|
@driesvints btw I suppose this PR is something critical since it affects the Stripe every time we use this page. |
|
@mehrancodes feel free to use a fork for now. |
|
Opened a new PR but preserved your commits: #987 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we're showing the card form only when it requires payment method and showing a confirm payment button when it requires action.
One other thing I have handled is the error code
payment_intent_authentication_failurewhen the 3D confirmation fails. when it happens, the payment intent status switches to therequire_payment_methodso we need to show the card form. that's why I have needed to passrequiresPaymentMethodandrequiresActionthrough the Controller so I can use them inside the Vue conditionally.If you're aware of a cleaner solution please let me know I appreciate it.
Thanks!
Closes #971