Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Document removePaymentMethod for Cashier Stripe #7559

Merged
merged 3 commits into from
Feb 4, 2022

Conversation

driesvints
Copy link
Member

No description provided.

@vlakoff
Copy link
Contributor

vlakoff commented Jan 7, 2022

The place where you insert this paragraph brings confusion. See the paragraph below the one you inserted: the paragraph for $user->deletePaymentMethods('sepa_debit') mentions the paragraph for $user->deletePaymentMethods().

Therefore, you should insert the new paragraph below the paragraph for $user->deletePaymentMethods('sepa_debit').

@driesvints
Copy link
Member Author

Thanks. Adjusted it so it's placed above it right below the other way to delete a specific payment method.

@taylorotwell
Copy link
Member

So what is the difference between deleteMethodMethods('sepa_debit') and removePaymentMethod('pm_visa')? Is there a reason one starts with remove and one starts with delete?

@driesvints
Copy link
Member Author

@taylorotwell hah, I contemplated to first send in a PR to cashier to consolidate the terminology before I sent in this one. I'll do that as well then.

deleteMethodMethods('sepa_debit') deletes all sepa debit payment methods.
removePaymentMethod('pm_visa') deletes a specific payment method by its ID.

In essence, a payment method is never truly deleted but rather detached from a customer. It continues to live on in Stripe if it's still needed for later payments in some edge cases.

@driesvints
Copy link
Member Author

Here you go: laravel/cashier-stripe#1298

@driesvints
Copy link
Member Author

Updated this PR as well

@taylorotwell
Copy link
Member

Marking as draft until Cashier release that includes new syntax.

@taylorotwell taylorotwell marked this pull request as draft January 7, 2022 15:43
@driesvints driesvints marked this pull request as ready for review February 4, 2022 10:26
@taylorotwell taylorotwell merged commit 8e10644 into 8.x Feb 4, 2022
@taylorotwell taylorotwell deleted the driesvints-patch-1 branch February 4, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants