Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate --pretend can actually create schema unless protected $connection is included in the migration #9059

Conversation

phpguru
Copy link

@phpguru phpguru commented Sep 28, 2023

In Issue 36596 it was reported that the php artisan migrate --pretend command will create schema elements on non-default database connections if the migration doesn't contain a protected $connection declaration.

This PR seeks to improve the Laravel 10.x documentation to address this apparent bug with php artisan migrate --pretend discussed in that thread.

@taylorotwell actually said, in part,

I'll make sure we are documenting this.

This PR seeks to make good on that promise, and prevent others (like me) from missing this information for any project with multiple databases.

…rate --pretend discussed in laravel/framework/issue/36596
@taylorotwell
Copy link
Member

No plans to add this atm.

@phpguru
Copy link
Author

phpguru commented Sep 29, 2023

@taylorotwell would you accept a PR against master? The lack of documentation around --pretend with multiple databases actually caused some trouble for us, which is how I found Issue 36596. This PR adds two sentences to the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants