Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fixes updating site aliases #135

Merged
merged 3 commits into from
Jan 14, 2022
Merged

Conversation

nunomaduro
Copy link
Member

This pull request fixes updating site aliases on Forge SDK, where using an empty list of aliases ['aliases' => []] as simply being not sent by guzzle.

// Before:
// PUT [...] aliases not updated OK
// PUT ['aliases' => []] aliases not updated KO <--- issue here...
// PUT ['aliases' => ['foo.com']] aliases updated OK

// After:
// PUT [...] aliases not updated OK
// PUT ['aliases' => []] aliases updated to empty OK <--- fixed now...
// PUT ['aliases' => ['foo.com']] aliases updated OK

At this time, because we are not sure of the ramifications of changing form_params by json globally - on the entire SDK - so we decided to apply it on this method (updateSite) only for now.

@taylorotwell taylorotwell merged commit 2ff2d03 into 3.x Jan 14, 2022
@taylorotwell taylorotwell deleted the fix/update-site-aliases branch January 14, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants