Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deleteSiteLog method to delete the site's log #185

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

pratikkuikel
Copy link
Contributor

This pull request adds a deleteSiteLog method to the Forge SDK which will allow developers to delete the site's log.

While this works fine for single log configuration.
I wonder what can be done if there are multiple log files present.

Maybe just like forge pulls in the 500 lines from the last updated file, deleting logs from the last updated file or log file for current day can be done for daily log configuration.

I wanted to create a feature request issue and I was redirected to create a pull request.
And here I am with my feature-request pull-request.

Thank you for your time and consideration.

@jbrooksuk jbrooksuk merged commit 1b7f1e9 into laravel:3.x Nov 12, 2024
10 checks passed
@jbrooksuk
Copy link
Member

Thanks!

@pratikkuikel
Copy link
Contributor Author

I made deleteSiteLog request and I am getting an exception :
{ "message": "The DELETE method is not supported for route api/v1/servers/xxxxx/sites/xxxxx/logs. Supported methods: GET, HEAD." }

    public function deleteSiteLog($server_id, $site_id)
    {
        return $this->site($server_id, $site_id)->deleteSiteLog();
    }

@olivernybroe
Copy link

Hey @pratikkuikel 👋

Sorry about that, we have shipped the logic now and the endpoint should be available.

@pratikkuikel
Copy link
Contributor Author

Thank you @olivernybroe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants