Allow bootable test traits to teardown. (#42521)

laravel · May 26, 2022 · a4723ec · a4723ec
1 parent cc23b2e
commit a4723ec
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 8 deletions.
diff --git a/src/Illuminate/Foundation/Testing/TestCase.php b/src/Illuminate/Foundation/Testing/TestCase.php
@@ -144,11 +144,13 @@ protected function setUpTraits()
         }
 
         foreach ($uses as $trait) {
-            $method = 'setUp'.class_basename($trait);
-
-            if (method_exists($this, $method)) {
+            if (method_exists($this, $method = 'setUp'.class_basename($trait))) {
                 $this->{$method}();
             }
+
+            if (method_exists($this, $method = 'tearDown'.class_basename($trait))) {
+                $this->beforeApplicationDestroyed(fn () => $this->{$method}());
+            }
         }
 
         return $uses;

diff --git a/tests/Foundation/Testing/BootTraitsTest.php b/tests/Foundation/Testing/BootTraitsTest.php
@@ -8,11 +8,17 @@
 
 trait TestTrait
 {
-    public $booted = false;
+    public $setUp = false;
+    public $tearDown = false;
 
     public function setUpTestTrait()
     {
-        $this->booted = true;
+        $this->setUp = true;
+    }
+
+    public function tearDownTestTrait()
+    {
+        $this->tearDown = true;
     }
 }
 
@@ -24,13 +30,18 @@ class TestCaseWithTrait extends FoundationTestCase
 
 class BootTraitsTest extends TestCase
 {
-    public function testSetUpTraitsWithBootMethod()
+    public function testSetUpAndTearDownTraits()
     {
         $testCase = new TestCaseWithTrait;
 
-        $method = new \ReflectionMethod(get_class($testCase), 'setUpTraits');
+        $method = new \ReflectionMethod($testCase, 'setUpTraits');
+        tap($method)->setAccessible(true)->invoke($testCase);
+
+        $this->assertTrue($testCase->setUp);
+
+        $method = new \ReflectionMethod($testCase, 'callBeforeApplicationDestroyedCallbacks');
         tap($method)->setAccessible(true)->invoke($testCase);
 
-        $this->assertTrue($testCase->booted);
+        $this->assertTrue($testCase->tearDown);
     }
 }