Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Fix route helper with custom binding key #32264

Merged
merged 4 commits into from
Apr 7, 2020
Merged

[7.x] Fix route helper with custom binding key #32264

merged 4 commits into from
Apr 7, 2020

Conversation

BSN4
Copy link
Contributor

@BSN4 BSN4 commented Apr 7, 2020 •
edited
Loading

fix #32201

thanks to @abdumu for helping me with this issue

@BSN4 BSN4 changed the title [7.x]f ix route helper with custom binding key [7.x] fix route helper with custom binding key Apr 7, 2020
@GrahamCampbell GrahamCampbell changed the title [7.x] fix route helper with custom binding key [7.x] Fix route helper with custom binding key Apr 7, 2020
@taylorotwell taylorotwell merged commit 38d9f84 into laravel:7.x Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbuzzibarrios rbuzzibarrios rbuzzibarrios approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

route() helper doesn't generate correct URI's for routes with a custom binding key
3 participants
@BSN4 @rbuzzibarrios @taylorotwell