-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.x] Fix whereNull
/whereNotNull
for json in MySQL
#32417
Conversation
whereNull
/whereNotNull
fir for json.whereNull
/whereNotNull
for for json.
whereNull
/whereNotNull
for for json.whereNull
/whereNotNull
for json.
|
@if4lcon is it work if key does not exist? Seems no? In any case |
whereNull
/whereNotNull
for json.whereNull
/whereNotNull
for json in MySQL
@staudenmeir do you have any feedback on this? |
Looks good to me. Great tests! |
@@ -244,4 +244,35 @@ protected function wrapJsonBooleanSelector($value) | |||
|
|||
return 'json_extract('.$field.$path.')'; | |||
} | |||
|
|||
protected function whereNull(Builder $query, $where) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing phpdoc.
return parent::whereNull($query, $where); | ||
} | ||
|
||
protected function whereNotNull(Builder $query, $where) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
Fixed PHP doc issues. |
This PR fixes #31473, please see issue for more details, in short:
PS: I tested it only for MySQL, probably would be good also test for MariaDB and Percona.