[7.x] Relative symlinks #32457
Merged
[7.x] Relative symlinks #32457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems kinda overkill to need a large symfony component just for this? |
|
The Symfony filesystem component is actually quite the opposite of "large". The entire component is basically one class. But yeah, maybe just put it into the suggest section. |
|
Made the current behavior the default. Changed flag to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up implementation of #32430, for your consideration.
Relative paths for links are determined by
makePathRelativefrom Symfony'sFilesystem, which handles Windows paths as well.