[7.x] Add takeUntil and takeWhile collection methods
#32496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosephSilber
changed the title
takeUntil and takeWhile collection methodstakeUntil and takeWhile collection methods
Merged
|
Looks like the circle is complete. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #32262, we added an
untilcollection method.That naming is quite unfortunate, given that
takeWhileis practically an industry standard. It's used by Rails, Python, Haskell, Lodash, RxJS, Java, Kotlin, C#/LINQ and countless others.In most cases, there are both
takeWhileandtakeUntilvariants.This PR introduces two new methods:
takeWhileandtakeUntil. The existinguntilmethod is now just an alias totakeUntil.I would also propose marking
untilas deprecated, and switch the docs to only showtakeUntilandtakeWhile.