[8.x] Fixes attempt to log deprecations on mocks #41057
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue that may happen when testing code looks like so:
In other words, the framework, and the attempt to log the deprecation, tries to resolve the Log instance that is a mock in this case. Now, because in tests, we only want to raise deprecations as errors when using the
withoutDeprecationHandling
, we can safely disable deprecation logs on unit tests.This needs to be included on L9 too.
Fixes #40942 (comment), and Mior's issue on Nova this morning: