[9.x] Change how Laravel handles strict morph map with pivot classes #41304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Generic Pivot class should always be ignored as it doesn't have any knowledge of the exact usage and generated automatically by Laravel. * Custom Pivot class should work the same as normal class since it defined manually by developer. In Laravel Nova, when we attach, update attached and detach resources we would store the pivot model in `action_events` table and this can cause issue when developer attempt to enable strict morph map. Signed-off-by: Mior Muhammad Zaki <[email protected]>
crynobone
commented
Mar 3, 2022
| @@ -39,7 +40,7 @@ public function testStrictModeDoesNotThrowExceptionWhenMorphMap() | |||
|
|
|||
| public function testMapsCanBeEnforcedInOneMethod() | |||
| { | |||
| $model = TestModel::make(); | |||
| $model = new TestModel; | |||
There was a problem hiding this comment.
faced issue while running test on single file:
Change to new TestModel fixed that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Laravel Nova, when we attach, update attached, and detach resources we
would store the pivot model in
action_eventstable and this can causeissue when the developer attempt to use
Relation::requireMorphMap().Signed-off-by: Mior Muhammad Zaki [email protected]