[9.x] Add Str::lcfirst to support non-ascii characters (vs php's core lcfirst fct) and add DX consistency with ucfirst wrapper
#41384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpratfr
changed the title
Str::lcfirst to support non-ascii characters (vs php's core lcfirst fct) and add DX consistency with ucfirst wrapper
vpratfr
changed the title
Str::lcfirst to support non-ascii characters (vs php's core lcfirst fct) and add DX consistency with ucfirst wrapperStr::lcfirst to support non-ascii characters (vs php's core lcfirst fct) and add DX consistency with ucfirst wrapper
vpratfr
added a commit
to vpratfr/docs-1
that referenced
this pull request
Mar 7, 2022
added in accepted PR: laravel/framework#41384
taylorotwell
pushed a commit
to laravel/docs
that referenced
this pull request
Mar 7, 2022
added in accepted PR: laravel/framework#41384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed in several projects a function to put the first character of a sentence as lower case (not the whole sentence).
Naturally I looked for it in the
Strclass as I know theucfirstfunction lives there, but noticed it was missing.I believe, by seeing the number of PRs to add this function to the framework, that many developers would enjoy this improvement to the DX. Getting consistency without having to macro the Str class in each of their projects.
So here is a non-breaking change to welcome the lcfirst function into the Str class.
It also works properly when lowercasing non ascii characters such as À or Ö, unlike the
lcfirstfunction from code PHP.