Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Fix excludeIf Validation Rule Docblock #41729

Merged
merged 1 commit into from
Mar 29, 2022
Merged

[9.x] Fix excludeIf Validation Rule Docblock #41729

merged 1 commit into from
Mar 29, 2022

Conversation

intrepidws
Copy link
Contributor

Fix incorrect docblock introduced in PR #41617.

@driesvints driesvints merged commit b9a34d0 into laravel:9.x Mar 29, 2022
@driesvints
Copy link
Member

Thanks!

@GrahamCampbell GrahamCampbell changed the title Fix excludeIf Validation Rule Docblock [9.x] Fix excludeIf Validation Rule Docblock Mar 29, 2022
@intrepidws intrepidws deleted the fix-excludeIf-validation-rule-docblock branch March 29, 2022 11:14
BrandonSurowiec added a commit to BrandonSurowiec/framework that referenced this pull request Jun 27, 2022
@BrandonSurowiec
[9.x] Fix ProhibitedIf docblock and constructor
38a74f0 
This applies the same fixes to ProhibitIf as ExcludeIf.
- Missing @throws declaration in docblock: laravel#41729
- Enforces a boolean in the constructor: laravel#41931 laravel#41969

Also fixes the ExcludeIf @var docblock to match as a \Closure
@BrandonSurowiec BrandonSurowiec mentioned this pull request Jun 27, 2022
Merged
taylorotwell pushed a commit that referenced this pull request Jun 27, 2022
@BrandonSurowiec
[9.x] Fix ProhibitedIf docblock and constructor (#42964)
1711a5c 
This applies the same fixes to ProhibitIf as ExcludeIf.
- Missing @throws declaration in docblock: #41729
- Enforces a boolean in the constructor: #41931 #41969

Also fixes the ExcludeIf @var docblock to match as a \Closure
taylorotwell pushed a commit to illuminate/validation that referenced this pull request Jun 27, 2022
@BrandonSurowiec
[9.x] Fix ProhibitedIf docblock and constructor (#42964)
11206ad 
This applies the same fixes to ProhibitIf as ExcludeIf.
- Missing @throws declaration in docblock: laravel/framework#41729
- Enforces a boolean in the constructor: laravel/framework#41931 laravel/framework#41969

Also fixes the ExcludeIf @var docblock to match as a \Closure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@intrepidws @driesvints