[9.x] Http client: retry callback exception handling (follow-up to #41762) #41792
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #41762.
Because the
retryWhenCallback
is now executed inside the globalretry
helper method, an extra attempt would be made if an exception occurred in theretryWhenCallback
. This was not the case when theretryWhenCallback
was used as a callback by the globalretry
helper method.By wrapping it in a try-catch, we can set
$shouldRetry
tofalse
before we throw the exception again. This ensures it does not make an unnecessary attempt.