[9.x] Catch permission exception when creating directory #41871
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flysystem v3 throws an exception when attempting to create a directory that already exists, and the correct permissions cannot be set.
I have added the
['throws' => false]
in my disks on theconfig/filesystems.php
file.For example, running
Storage::makeDirectory('test')
from artisan (console kernel) creates thetest
directory with the console user and appropriate permissions.Then, running
Storage::makeDirectory('test')
from the web (http kernel), throws an exception because the directory exists, and attemps to change the permissions, while the web user is not the same as the console user, so it fails.Since Laravel allows to return false instead of throwing exceptions, this exception should be handled.
The same exception is already handled in the
Storage::setVisibility()
method.Also, it should probably be handled in the
writeStream
andput
methods?