[9.x] Restore v8 behaviour of base query for relations #41923
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As commented on #41918 I found a new inconsistency in the Laravel 8.x and 9.x implementation with the fix by @driesvints.
In Laravel v8 the implementation for getBaseQuery was:
With the recently merged fix it's now the following which is different (it's now applying the scope!):
I restored the exact behavior of Laravel 8.x that
getBaseQuery
andtoBase
are both operating directly on theEloquent\Builder
object. So any change inEloquent\Builder::toBase()
is also automatically reflected onRelationship::toBase()
as in Laravel 8.x.