-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.x] Prettify the event:list command #41977
Conversation
6273ac0
to
8bf6e59
Compare
This is a breaking change, no? |
|
50b851d
to
54dc203
Compare
54dc203
to
84c5e35
Compare
I also meant the fact that the output was changing. |
@GrahamCampbell I personally don't consider that part of the public API but let's see what Taylor says. |
Personally I'd like to see the formatting be a bit more in line with |
Actually I did start a PR for that, will find the time to finish it |
Also @imanghafoori1 let me know if you want to match the look with route:list on this PR. |
no problem, I will try to make it consistent tonight,
|
Awesome @imanghafoori1, if you need any help, let me know ;) |
@xiCO2k Thank you very much, currently working on it, and I will push the results in an hour or so. |
2a13769
to
b3282c8
Compare
With the push of the second commit, I am done. \(^_^)/ |
@xiCO2k can you share what your version looked like? |
b3282c8
to
c2e1181
Compare
Personally I like the third one best... with an empty line added in between new events to give it a bit more breathing room. 👍 Simple and clean. 🧼 |
I can PR that style change, and then @imanghafoori1 after the merge can PR those cool additions to show What do you guys think? |
@xiCO2k I have no idea, actually. |
@xiCO2k sure go ahead and send over your style change. |
The current form of printing a table for showing events/listeners is very sensitive to the width of the command line. In this form, we can survive much smaller screens.
ShouldQueue
andShouldBroadcast
interface.The new output is responsive to the width of the terminal window and trims the long lines.
You may change the text and color to your liking.