[9.x] Fix TrimStrings middleware with non-UTF8 characters #42065
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
TrimStrings
middleware sets tonull
all requests inputs with a unicode character not in UTF-8, which can be really frustrating to debugIt can be reproduced by using a
POST
request with a body likefoo=abcd%E9
: thefoo
input will just benull
if theTrimString
middleware is used.This issue was introduced in #40600, because
preg_replace
withu
flag will returnnull
for a non-UTF8 input (withMalformed UTF-8 characters, possibly incorrectly encoded
aspreg_last_error_msg()
)As a fix, when
preg_replace
return anull
value, it's simply pass the value to the PHPtrim
function, which was the behavior used by Laravel for years. This doesn’t change the current behavior for valid UTF-8 inputs.