[8.x] Fix deprecation issue with translator #42216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
This was referenced May 2, 2022
GrahamCampbell
requested changes
May 2, 2022
| @@ -218,8 +218,8 @@ protected function makeReplacements($line, array $replace) | |||
| $shouldReplace = []; | |||
|
|
|||
| foreach ($replace as $key => $value) { | |||
| $shouldReplace[':'.Str::ucfirst($key)] = Str::ucfirst($value); | |||
| $shouldReplace[':'.Str::upper($key)] = Str::upper($value); | |||
| $shouldReplace[':'.Str::ucfirst($key ?? '')] = Str::ucfirst($value ?? ''); | |||
There was a problem hiding this comment.
I don't think keys can ever be null?
There was a problem hiding this comment.
I only fixed the behavior that was previously in place. In any PHP version before 8.1, if null was used as a replacement it'd be casted to a string. Since PHP 8.1 throws a deprecation for this, we'll need to make sure to do this ourselves.
We can't change the behavior of handling null on 8.x or 9.x as that'd be a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where a translation param was null and triggers a deprecation warning in PHP 8.1. On lower PHP versions, the parameter is simple added as an empty string.
See #42204