-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overriding console command constructor is bad practice #42454
Closed
Closed
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
bfa0315
Create new type console command
adideas cf26b9a
create console-protected.stub
adideas 2e34ebe
Update stub for protected command
adideas dc3acb3
Add confirm for create protected console command
adideas f8390ec
Update code style for ProtectedComand
adideas ecefd5c
Update code style for ConsoleMakeCommand
adideas 3c779ba
Update code style for ProtectedCommand
adideas 4e5f6a3
Rolled back the change "ConsoleMakeCommand.php"
adideas 2bc381c
StyleCI update code style
adideas 17504f1
Rolled back the change
adideas 647819b
Update ConsoleMakeCommand.php
adideas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
<?php | ||
|
||
namespace Illuminate\Console; | ||
|
||
use Symfony\Component\Console\Input\InputInterface; | ||
use Symfony\Component\Console\Output\OutputInterface; | ||
|
||
class ProtectedCommand extends Command | ||
{ | ||
/** | ||
* Create a new console command instance. | ||
* Not used for protected command. | ||
* | ||
* @return void | ||
*/ | ||
final public function __construct() | ||
{ | ||
parent::__construct(); | ||
} | ||
|
||
/** | ||
* Execute the console command. | ||
* Not used for protected command. | ||
* | ||
* @return int | ||
*/ | ||
final public function handle() | ||
{ | ||
return 0; | ||
} | ||
|
||
/** | ||
* Execute the console command. | ||
* | ||
* @param \Symfony\Component\Console\Input\InputInterface $input | ||
* @param \Symfony\Component\Console\Output\OutputInterface $output | ||
* @return int | ||
*/ | ||
protected function execute(InputInterface $input, OutputInterface $output) | ||
{ | ||
if (method_exists($this, '__invoke')) { | ||
return (int) $this->laravel->call([$this, '__invoke']); | ||
} | ||
|
||
return 1; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
src/Illuminate/Foundation/Console/stubs/console-protected.stub
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
<?php | ||
|
||
namespace {{ namespace }}; | ||
|
||
use Illuminate\Console\Command; | ||
use Illuminate\Console\ProtectedCommand; | ||
|
||
/** | ||
* Use "__invoke()" method | ||
* Inject dependencies "__invoke(Application $application)" | ||
* | ||
* This console command is protected. | ||
* To make the current command unprotected change extend class to "Command" | ||
* | ||
* Example: class {{ class }} extends Command {} | ||
* @see Command | ||
*/ | ||
class {{ class }} extends ProtectedCommand | ||
{ | ||
/** | ||
* The name and signature of the console command. | ||
* | ||
* @var string | ||
*/ | ||
protected $signature = '{{ command }}'; | ||
|
||
/** | ||
* The console command description. | ||
* | ||
* @var string | ||
*/ | ||
protected $description = 'Command description'; | ||
|
||
/** | ||
* Execute the console command. | ||
* | ||
* @return int | ||
*/ | ||
public function __invoke() | ||
{ | ||
return 0; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also revert this.