[9.x] Model::whereRelation ignores the callback function or does it wrong

[adideas]

Eloquent

$userSQL = User::whereRelation(
    "posts",
    function($query) {
        // THIS
        $query->selectRaw("id")->limit(1)->where("public", true);
    }
)->toSql();

Query

$dbSQL = DB::table("users")->whereExists(
    function ($builder) {
        // relations simulation
        $builder->from("posts")->addSelect(['*'])->whereColumn(
            'users.id', '=', 'posts.user_id'
        );
        // THIS
        $builder->selectRaw("id")->limit(1)->where("public", true);
    }
)->toSql();

Eloquent output

select * 
from "users" 
where exists (
   select * 
   from "posts" 
   where "users"."id" = "posts"."user_id" and ("public" = ?)
)

Query output

select * 
from "users" 
where exists (
   select *, id 
   from "posts" 
   where "users"."id" = "posts"."user_id" and "public" = ? limit 1
)

[adideas]

I agree I could have used a different method. For example "whereHas" instead of "whereRelation".
But I thought that it should work correctly.

I added tests for checks. I can improve them if needed in the next pull request.

[adideas]

As I understand it, the last one who changed this code was Italo DarkGhostHunter.
Pull Request [8.x] Adds a simple where helper for querying relations #38499
@DarkGhostHunter -> Adds simple where helper for relations. 23 Aug 2021

[DarkGhostHunter]

(checking...)

[DarkGhostHunter]

Well, it's expected:

Add a basic where clause to a relationship query.

I don't remember why I didn't do that in the first place, I think it was because the callback was already handled by Eloquent where() and it doesn't replaces whereHas(), which is a convenience method for has() with a callback where you have more control.

[adideas]

Well, it's expected:

Add a basic where clause to a relationship query.

I don't remember why I didn't do that in the first place, I think it was because the callback was already handled by Eloquent where() and it doesn't replaces whereHas(), which is a convenience method for has() with a callback where you have more control.

@DarkGhostHunter I'm sorry I commented on you. I thought you should see.

[adideas]

@GrahamCampbell "Changed name" Thanks for correcting me!

[taylorotwell]

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

[taylorotwell]

We don't document using these methods this way.

[adideas]

@taylorotwell I did an analogy.
where(callback)
...
has('relation', '>=', 1, "and", callback)
whereHas('relation', callback)
whereRelation() // no callback function
doesntHave('relation', operator, callback)
whereDoesntHave('relation', callback)
whereHasMorph('relation', [], callback)
whereDoesntHaveMorph('relation', [], callback)

I agree it's not in the documentation.
But as I understood by researching other methods, it is always possible to specify a callback function.
Also, not everything is described in the documentation.

Example 1 (method has)
There is no information that the 4th argument is a callback.
Example 2 (method doesntHave)
There is no information that the 3th argument is a callback.

In the last pull request you told me.
"All changes should follow the Laravel approach."
I believe that the current change does not violate the Laravel approach.

The developer who implemented this method said. DarkGhostHunter: I don't remember why I didn't do that in the first place, I think it was because the callback was already handled by Eloquent where() and it doesn't replaces whereHas(), which is a convenience method for has() with a callback where you have more control.

I have used this method. I needed to pass a callback function. I have read the documentation. But this was not in the documentation. I started looking for ways to do it differently. I found the answer not in the documentation. I looked at the source code. Found that this is a wrapper over whereHas. I thought. Why can't I pass a callback function properly?
Isn't that logical?

I don't know why you think the current addition is wrong.
I followed the Laravel approach.
This is not a critical addition.
You or I can add information to the documentation.

Tell me how it would be better. I'll fix it.

[adideas]

// One is enough for me. Which will reduce the burden.
User::whereRelation("posts", function($query) {
   $query->limit(1);
})

But I can't do that! Why?
I have to use "whereHas".
What's the point in "whereRelation"?
I don't know!

I can add documentation!

[adideas]

@taylorotwell I think we're talking about a supplement. I'm not sure if this is a mistake. But many expect a different result using this method.

[adideas]

please show this