[9.x] Add counts to route:list command #42551
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again! This is just another small PR to the
route:list
command that I think could come in handy. It adds 2 counts to the CLI output showing the amount of routes that are being displayed. One count is placed at the bottom and one is placed at the top.Here's an example of how it could look if you don't have a lot of routes and can see both counts:
Here's an example of how it could look if you have a lot of routes and can only see the bottom count:
I think could just be another small UI nicety to make the route list even easier (and quicker) to read and understand.
I couldn't seem to get the tests fully working for this. I have a feeling that it might be something to do with me outputting the same line twice, but that's just a guess. But I have updated the tests to pass with what I've done so far.
If you think this is something that might be worth merging, please let me know if you'd like any changes making 😄