[9.x] Fix getting '0' from route parameter in Authorize middleware #42582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the following :
Calling
GET api/sin/90
will correctly pass but callingGET api/sin/0
will fail in the policy because$angle
isnull
instead of expected0
.Problem comes from the fact that
$request->route($model, null)
is'0'
and'0' ?: 'bar'
is'bar'
.Changing the Elvis
?:
to null coalesce??
solves the issue.