Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Fix undefined constant error when use slot name as key of object #42943

Merged

Conversation

monurakkaya
Copy link
Contributor

It's solution for #42932

I've described problem in the issue.

With 9.15 and after we cannot use <x-slot :name="$model->name"> because it is rendering as

<?php $__env->slot($model>name, null, []); ?>

instead

<?php $__env->slot($model->name, null, []); ?>

@monurakkaya monurakkaya changed the title Slot name as object key with tests [9.x] Fix undefined constant error when use slot name as key of object Jun 24, 2022
@monurakkaya
Copy link
Contributor Author

@taylorotwell I’ve added the test which will fail on 9.15 - 9.18 tags.

@taylorotwell taylorotwell merged commit 3b3a568 into laravel:9.x Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants