-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.x] Artisan about
Command
#43147
[9.x] Artisan about
Command
#43147
Conversation
This is great, for package maintainers, it will allow us to more easily get debugging information from our users, which will help us fix issues. Not just version numbers, but checking if they have fallen into common traps like not linking their public storage directory. Very nice! |
Might be cool to have and specific sections broken down by key because the about page might get pretty lengthy
I could see a nice package for
|
Another approach for many packages could be adding comma-separated filters: php artisan about --only=environment,laravel_nova |
Great PR, it's a little hard to read though with the values being so far from the keys. Especially in full screen. |
@pxlrbt: wouldn't it be better using the |
Okay, I've added I've also added an |
That is the problem I am bringing up. Full-screen terminal windows will have the key/values separated by a lot of dots, making it difficult to read because they are on opposite ends of the screen. It's not a huge issue, but maybe there are other, more legible layout options out there. |
I agree with @voidgraphics, from a UX standpoint, the left-aligned words and the right-aligned words are too far away from each other, and the dot leaders do not always help when a terminal window is full-width. This design is generally used in table of contents in books, or in restaurant menus, where the page layout is portrait (the width is narrower than the height). It does not work so well in landscape layouts, where the eyes have to scan a lot of width to match the left word with the right word. |
We'll address this in the Console UI Improvements PR, on which this PR is based on. |
e8ddee8
to
8a14a60
Compare
@jbrooksuk Just a thought: How about getting rid of the php artisan about environment
php artisan about environment laravel_nova some_other_section --json |
2fb0fc1
to
1daf66c
Compare
1daf66c
to
a7f16e7
Compare
Great work! @jbrooksuk 👏🏻 |
This PR introduces a new
about
command that displays output about the system environment and configuration of the user's application. The command is inspired by Rails' ownabout
command, though it's beautiful and has some additional powers 🪄The command includes its own API so that applications and packages may push data into existing sections or create a new section with its own data:
You can also add multiple items:
It's expected that packages will start to add their own sections of information, which could make this command output a lot of information. You can choose to filter down certain sections with
--only
and pass a comma-separated list of sections insnake_case
.Finally, you can choose to output this information as JSON by using the
--json
option (which can also be combined with--only
):