Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Fixes for model:show command #43301

Merged
merged 3 commits into from
Jul 20, 2022
Merged

[9.x] Fixes for model:show command #43301

merged 3 commits into from
Jul 20, 2022

Conversation

jessarcher
Copy link
Member

@jessarcher jessarcher commented Jul 20, 2022 •
edited
Loading

This PR fixes a few issues with the model:show command:

  • Fixes compatibility with PHP 8.0
  • Prevents throwing an error when the relation detection returns a false positive
  • Fixes an issue when a model has the same name as a facade

Fixes #43298
Fixes #43285
Fixes #43289

This was referenced Jul 20, 2022
Closed
Closed
@jessarcher jessarcher mentioned this pull request Jul 20, 2022
Closed
@nunomaduro nunomaduro changed the title Fixes for model:show command [9.x] Fixes for model:show command Jul 20, 2022
@nunomaduro nunomaduro mentioned this pull request Jul 20, 2022
Closed
@taylorotwell taylorotwell merged commit f450945 into 9.x Jul 20, 2022
@taylorotwell taylorotwell deleted the model-show-fixes branch July 20, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebdesign sebdesign sebdesign left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jessarcher @sebdesign @taylorotwell