-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.x] Improves serve
Artisan command
#43375
Conversation
@nunomaduro new implementation missing PHP version. Not sure it's really important, but may be useful in some edge cases. |
It's intentional. |
I'm getting an error serving from specific port and host. I think this can be resolved by putting an isset around the array of matches.
This occures when running serve this way: and accessing the served site via |
Rather than showing |
@ankurk91 It's not possible due PHP Built-in server limitations. |
* Improves `serve` Artisan command * Handles better edge cases * Removes assets requests, and displays unexpected output as "warn" * Simplifies command and handles assets * Better captures * formatting Co-authored-by: Taylor Otwell <[email protected]>
This pull request improves Laravel's
serve
artisan command. Here is the difference:So, the output got improved. The "time" is the only information highlighted, as is the only thing that actually changes. And we got to see a "rounded" duration of the request.
Note that, because we are using PHP's built-in server using a file such as "server.php", we don't have information regarding the Method, Uri, Response Code, etc.
In addition, unexpected output such as port already in use, or
.env
got changed, is displayed this way: