[9.x] Fixes Artisan serve command on Windows

[nunomaduro]

This pull request fixes the serve command when being used on Windows.

Fixes #43433.

[antonkomarev]

I hope some day we will have env independent constant in PHP for \n

[JohnRoux]

This seems to have broken the serve command for me.
When I have a --host argument with subdomains, any page load at all on localhost results in this error:

 ErrorException 

  Undefined array key 0

  at vendor/laravel/framework/src/Illuminate/Foundation/Console/ServeCommand.php:252
    248▕                 preg_match('/\:(\d+)/', $parts[1], $matches);
    249▕ 
    250▕                 $request = $this->requestsPool[$matches[1]];
    251▕ 
  ➜ 252▕                 [$startDate, $file] = $request;
    253▕                 $formattedStartedAt = $startDate->format('Y-m-d H:i:s');
    254▕ 
    255▕                 unset($this->requestsPool[$matches[1]]);
    256▕ 

[nunomaduro]

When I have a --host argument with subdomains, any page load at all on localhost results in this error:

Can you elaborate?

[JohnRoux]

Sorry, this isn't actually the right PR.
I've having the same problem as on this PR

Stock laravel install with Nova4 and trying to use --host seems to be giving me that same problem.
I'm not running windows either fwiw, running ubuntu 20.04

I ended up forceably downgrading to 9.20.0 to get my serve command working

[nunomaduro]

You also have the issue using the latest version of Laravel? If yes, can you share the exact command with me?

[JohnRoux]

Yeah, same issue on latest 9.x most recently updated:

php artisan serve --host rouxtaccess.slackboard.localhost

[nicolaibaaring]

I have the same issue on Laravel version 9.22.1 and Windows 10. The command is php artisan serve but I'm loading a custom ServeCommand with the following settings:

    protected function getOptions()
    {
        return [
            ['host', null, InputOption::VALUE_OPTIONAL, 'The host address to serve the application on.', 'sub.domain.site'],
            ['port', null, InputOption::VALUE_OPTIONAL, 'The port to serve the application on.', 8088],
            ['no-reload', null, InputOption::VALUE_OPTIONAL, 'Instruct the built-in server to not reload the server when environment file changes.', false],
        ];
    }

The problem does not occur when there is no custom serve command, but if the same settings are set manually on the terminal command php artisan serve --host="sub.domain.site" --port=8088 , then the problem is the same.
The actual input for host and port do not matter. Any custom input will cause the problem.

I can create two (maybe) different versions of the error. One has the error Undefined array key 0 (on line 252) and the other one has the error Undefined array key XXXX (on line 250), where XXXX is the from the request
"[Thu Jul 28 12:55:28 2022] [nnnn::XXXX:nnnn:nnnn:nnnn]:NNNNN Closing"

I hope it helps the debugging.

[nunomaduro]

Working on this - should be ready today.

[nunomaduro]

@nicolaibaaring @JohnRoux can you test the contents of this pull request in your project? #43461.

[JohnRoux]

Hey, confirmed that it's working for me 🚀

I swapped out my laravel/framework in composer for this

"laravel/framework": "dev-fix/serve-command-with-host as 9.22.2",

And it doesn't have the serve problem on either of the two app's which 9.* currently breaks on

[nunomaduro]

Waiting for your @nicolaibaaring feedback now.

[nicolaibaaring]

That also works on my side. I've tested on two projects too. Thanks for your efforts.