[9.x] Extract child route model relationship name into a method #43597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orkhanahmadov
changed the title
Ken-vdE
pushed a commit
to Ken-vdE/framework
that referenced
this pull request
Aug 9, 2022
…vel#43597) * Extract child route model relationship name * Fix style * Update Model.php Co-authored-by: Taylor Otwell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change extracts the child route model relationship name into a dedicated protected method.
The previous approach always assumes that the plural name of the relationship is going to be used for the relationship. But this is not always the case, if the parent is using the
hasOnerelationship, usually the method name for this relationship is in a singular form, not plural. But the previous approach always tries to resolve it as plural.Having a dedicated method for child route relationship name makes it possible to conditionally provide different relationship name depending on
$childType.