[9.x] Call prepare()
on HttpException
responses
#43895
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
AbstractRouteCollection::handleMatchedRoute()
throws aNotFoundHttpException
, the generated response is never passed throughRouter::toResponse()
which calls theResponse::prepare()
method.The end result of this is that the when a non-existing route is called the response doesn't contain the
Content-Type: text/html
header and the response may not be rendered correctly, depending on whether the web server will "intelligently" add theContent-Type
header.I ran into this when running Octane using my own AWS Lambda handler that doesn't correct this, like
vapor-core
does.