[9.x] Fix Stringable typehints with Enumerable #44030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgaal
commented
Sep 6, 2022
| * @param string|string[]|Enumerable<array-key, string> $subject | ||
| * @param string|array<string>|Enumerable<array-key, string> $search | ||
| * @param string|array<string>|Enumerable<array-key, string> $replace | ||
| * @param string|array<string>|Enumerable<array-key, string> $subject | ||
| * @return string | ||
| */ | ||
| public static function replace($search, $replace, $subject) |
There was a problem hiding this comment.
We could also make this work with iterable, but then we need to call iterator_to_array, which might not be as efficient? Not sure if that's true though.
There was a problem hiding this comment.
Made it work with iterable now. Did some benchmarks and tried to keep the same performance by not over-naively passing everything to collect.
|
This makes sense. PHPStan documentation says:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug with static analysis using PHPStan that was introduced in #44012. I've taken the liberty of making the
StrandStringablehelpers work with iterators where possible, and broadened the types as well.Below is an example of the errors and how they are fixed now.
https://phpstan.org/r/a8f703b0-5d8c-470e-8b7f-2ce3adbcdf1a