[9.x] Fix bug in Fluent Class with named arguments in migrations #44251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why would you use a named argument there? |
|
why not? |
|
It's a one argument method. There is no point? |
|
if PHP by default makes it possible to use named arguments even with only 1 parameter, why shouldn't Fluent too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used named arguments on migration methods, e.g:
$table->boolean('isActive')->default(value: true);the Fluent Class throws a Exception with "Undefined array key"This fixes the way to get the first value on $parameter from array index to reset()