Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Improves dd source on compiled views #44347

Merged
merged 6 commits into from
Sep 28, 2022
Merged

[9.x] Improves dd source on compiled views #44347

merged 6 commits into from
Sep 28, 2022

Conversation

nunomaduro
Copy link
Member

@nunomaduro nunomaduro commented Sep 28, 2022 •
edited
Loading

This pull request is inspired by #44334, and co-authored by baselrabia, and it improves displaying the dd source on compiled views.

// resources/views/welcome.blade.php on line 23...
@php dd('hey'); @endphp

// Before
"hey" // storage/framework/views/6687c33c38b71a8560bb0c404ec753054fa3a941.php:23

// After
"hey" // resources/views/welcome.blade.php

Fixes #44334

@nunomaduro nunomaduro mentioned this pull request Sep 28, 2022
Closed
@nunomaduro nunomaduro self-assigned this Sep 28, 2022
@nunomaduro nunomaduro marked this pull request as ready for review September 28, 2022 14:01
@nunomaduro nunomaduro force-pushed the feat/improve-dd-source-on-compiled-views branch from 6ac1590 to 79f3e54 Compare September 28, 2022 14:35
@sebdesign
Copy link
Contributor

Does this work with the @dd directive as well?

@nunomaduro
Copy link
Member Author

@sebdesign Yes.

@taylorotwell taylorotwell merged commit c86e883 into 9.x Sep 28, 2022
@taylorotwell taylorotwell deleted the feat/improve-dd-source-on-compiled-views branch September 28, 2022 19:19
@nunomaduro nunomaduro mentioned this pull request Sep 29, 2022
Closed
@SudoGetBeer SudoGetBeer mentioned this pull request Sep 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylorotwell taylorotwell Awaiting requested review from taylorotwell

Assignees

@nunomaduro nunomaduro

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nunomaduro @sebdesign @taylorotwell