[9.x] only load trashed models on relevant routes #44478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `index`, `create`, and `store` don't use route model binding, so from a performance and simplicity standpoint, we don't need to load those routes with trashed models - it doesn't make a lot of sense to load soft deleted models on the `destroy` route.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was writing the docs for #44405, I came to the realization it didn't make a lot of sense to load trashed models for some of the default resource routes. This PR will make it so calling
->withTrashed()with no arguments only loads trashed models on theshow,edit, andupdateroutes.index,create, andstoredon't use route model binding, so from a performance and simplicity standpoint, we don't need to load those routes with trashed modelsdestroyroute.Curious to hear if there'd be any argument for continuing to load soft deleted models on the
destroyroute.If this gets merged before next Tuesday's release we'll be okay keeping this on 9.x, since it's technically a breaking change.
If this gets merged I'll need to make a minor adjustment to laravel/docs#8277