[10.x] When should return the callback value rather than the conditionable object #44724
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue in #44712
When using the
when()
on the Collection instance, it used the null-coalescing operator to return the conditionable concern rather than simply returning the callback.This caused multiple issues, for example;
This causes the value to be null, leaving the null-coalescing operator to return the $this; which was not really the expected behavior. You would want the value to just return whatever the method returns you instead.
This could be a really nice upgrade for 10.x so the when method doesn't all of a sudden take over the responsibility of returning the correct value.