Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Throw meaningful exception when broadcast connection not configured #44745

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

bonroyage
Copy link
Contributor

Currently, when you configure your application to use a broadcasting driver that is not configured, it throws an exception because it's unable to read the driver key from null.

image

Other managers, like the CacheManager and LogManager, each check if the $config is null and throw a meaningful exception describing what is wrong. This PR adds the same logic to the BroadcastManager, so the resulting exception is:

image

@taylorotwell taylorotwell merged commit ec3958d into laravel:9.x Oct 26, 2022
@bonroyage bonroyage deleted the broadcast-config-exception branch October 26, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants