[9.x] Remove __sleep() & __wakeup() from SerializesModels trait.
#44847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-kujawa
force-pushed
the
9.x-remove_sleep_and_wakeup
branch
from
a33a6bb to
a5ce9e5
Compare
r-kujawa
changed the title
__sleep() & __wakeup() from SerializesModels trait.
joeyrush
pushed a commit
to Nutickets/laravel-actions
that referenced
this pull request
Feb 21, 2023
|
Really wish this was targeted at Laravel 10 given methods were removed. 🤦 |
|
@adrianb93 but these methods aren’t used anymore. |
|
Just a bit of a deployment panic. A package we use referenced it and some of our code also used this trait and had it's own |
|
It was never meant for these methods to be overwritten. We can't protect against everything people do in userland. |
bjuppa
added a commit
to kontenta/kontour
that referenced
this pull request
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes support for the
__sleep()&__wakeup()methods in theSerializesModelstrait, since they have become irrelevant in Laravel 9.x as the minimum requirements are PHP 8.0. In this version of PHP the__serialize()method will be called instead of the__sleep()method and the__unserialize()method will be called instead of the__wakeup()method.I believe the reason why both magic methods were still present in this trait was to keep supporting PHP 7.3 in Laravel 8.x.
Documentation reference