Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Optimize whereKey method πŸƒπŸ»β€β™‚οΈ #45453

Merged
merged 1 commit into from
Dec 30, 2022

Conversation

imanghafoori1
Copy link
Contributor

@imanghafoori1 imanghafoori1 commented Dec 29, 2022

If whereIntegerInRaw performs better, why not use it when filtering the numeric Primary-key columns?
This change also improves higher-level methods like findMany and etc, so their tests are updated.

@imanghafoori1 imanghafoori1 changed the title [9.x] Optimize whereKey [9.x] Optimize whereKey method Dec 29, 2022
@imanghafoori1 imanghafoori1 force-pushed the where_key branch 2 times, most recently from 358bf37 to 7c20173 Compare December 29, 2022 18:51
@imanghafoori1 imanghafoori1 changed the title [9.x] Optimize whereKey method [9.x] Optimize whereKey method πŸƒπŸ»β€β™‚οΈ Dec 29, 2022
@taylorotwell taylorotwell merged commit 8c6d066 into laravel:9.x Dec 30, 2022
@imanghafoori1 imanghafoori1 deleted the where_key branch December 30, 2022 15:51
driesvints added a commit that referenced this pull request Jan 10, 2023
@driesvints
Copy link
Member

We're reverting this as it's causing a breaking change when using arrays: #45582

@imanghafoori1
Copy link
Contributor Author

Can I seek a fix to the reported bug and avoid the revert?

@driesvints
Copy link
Member

You're free to attempt a new PR πŸ‘

@imanghafoori1
Copy link
Contributor Author

I am seeking the root cause of that right now, Hopefully, I can find it within an hour or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants