-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.x] Improve decimal cast precision #45457
Conversation
On hold until #45492 is merged. |
@timacdonald I guess this can be continued to work on now that PR is merged? |
09bdab1
to
5bec618
Compare
5bec618
to
20d669d
Compare
@timacdonald I moved the bc-math requirement to "suggest" which is what you wanted to do I think. |
If it's in the suggest, then it crashes? |
@barryvdh it's in "suggest" because you don't have to use the decimal cast per se. It's suppose to crash if you don't have it installed. That's why it's a "suggest" and not a hard dependency. Also, I think you wanted to link to a different PR? |
Remove manual manipulation and require
bcmath
to use the decimal cast.This should be noted in the 10.x upgrade guide.