Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow SMTP TLS to be set for all ports #45900

Closed
wants to merge 1 commit into from

Conversation

leinelissen
Copy link

This reverts PR #40943
This resolves #45899

Basically, this allows for setting TLS settings on ports other than 465. If someone wants to use STARTTLS, they should set MAIL_ENCRYPTION to null and Symfony Mailer will automatically upgrade the connection if STARTTLS is available.

@taylorotwell
Copy link
Member

So how does this not just put right back in the situation that people were saying was broken?

@leinelissen
Copy link
Author

If you want I can add documentation that clarifies configuration for TLS and STARTTLS in the SMTP transporter. I've also looped in the author of the other PR to find out what the underlying problem was.

Regardless, I feel the current situation hurts SMTP configurability so I do want to propose this as a necessary change.

@leinelissen
Copy link
Author

Alternatively, we can change the syntax so that it much more closely resembles how Symfony Mailer is currently setup. That requires more modifications and I think that would be a breaking change though.

@taylorotwell
Copy link
Member

Can't merge this PR if we're just going back to something people were complaining about.

@leinelissen
Copy link
Author

Would it be okay if I manage to convince the original author and verify it won't cause any issues for them?

@taylorotwell
Copy link
Member

It wasn't just the original author - there were lots of people in that thread?

@taylorotwell
Copy link
Member

Added this: 68a8bfc

@leinelissen leinelissen deleted the fix/smtp-tls-ports branch February 1, 2023 15:30
@leinelissen
Copy link
Author

Yeah that's perfect, thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot set TLS for email on port other than 465
2 participants