Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Fixes parameter declaration for ServiceProvider::optimizes() #53074

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

crynobone
Copy link
Member

@crynobone crynobone commented Oct 9, 2024

While the deprecation exists in PHP 8.4, the docblock are still in-correct and doesn't match the 3rd params.

Illuminate\Support\ServiceProvider::optimizes(): Implicitly marking parameter $optimize as nullable is deprecated, the explicit nullable type must be used instead
Illuminate\Support\ServiceProvider::optimizes(): Implicitly marking parameter $clear as nullable is deprecated, the explicit nullable type must be used instead

Introduced via #52928

```
Illuminate\Support\ServiceProvider::optimizes(): Implicitly marking parameter $optimize as nullable is deprecated, the explicit nullable type must be used instead
Illuminate\Support\ServiceProvider::optimizes(): Implicitly marking parameter $clear as nullable is deprecated, the explicit nullable type must be used instead
```

Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone crynobone marked this pull request as ready for review October 9, 2024 03:16
@crynobone crynobone merged commit 6e91690 into 11.x Oct 9, 2024
31 of 34 checks passed
@crynobone crynobone deleted the php84-compat branch October 9, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant