[11.x] Use PHP 8.4 array helpers #53426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnoordsij
force-pushed
the
use-php-array-helpers
branch
2 times, most recently
from
66e1f23 to
7ae23bc
Compare
|
Hi there, can you rebase this PR to Adding this wouldn't include PHP 8.4 on our CI build is highly dangerous. |
jnoordsij
force-pushed
the
use-php-array-helpers
branch
from
7ae23bc to
674c8d4
Compare
|
If the current code is working I would just leave it. 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.4 introduces new array search functions for finding items matching criteria or determining if any/all of them pass. See also https://php.watch/versions/8.4/array_find-array_find_key-array_any-array_all.
This PR introduces these helpers in the
ArrandCollectionclasses to use 'modern' logic for the case where these functions are available. If in the future the minimal PHP version is 8.4, this will allow for further simplification by removing the old logic altogether.Requires #52633 to be merged or to be merged into #52633.