[12.x] remove faker property from Factory
#53440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`$this->faker` is the old way of doing things, and ALL the documentation says to use `fake()`, which also gives some localization benefits. we should remove the property from `Factory` to cleanup the code and prevent its use. the `WithFaker` trait is has never been documented as far as I can tell, and `fake()` should be used instead now anyway.
|
Hmm, I'm not sure this breaking change is worth it for end users since the maintenance burden on our end is so small. |
|
@taylorotwell I don't disagree that the maintenance burden right now is small, but I do feel the day will come when Laravel has to make the decision to remove some of this code for the health of the framework. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$this->fakeris the old way of doing things, and ALL the documentation says to usefake(), which also gives some localization benefits. we should remove the property fromFactoryto cleanup the code and prevent its use.the
WithFakertrait is has never been documented as far as I can tell, andfake()should be used instead now anyway.the
fake()helper was introduced in #42844 2 years ago.