Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Update docblocks using latest documenter #53550

Merged
merged 2 commits into from
Nov 18, 2024
Merged

[11.x] Update docblocks using latest documenter #53550

merged 2 commits into from
Nov 18, 2024

Conversation

timacdonald
Copy link
Member

@timacdonald timacdonald commented Nov 18, 2024

Made some updates to the documenter to support:

  1. Resolving generics that are "of type", e.g., TGrammar of \Illuminate\Database\Grammar
    /**
     * Set the table prefix and return the grammar.
     *
     * @template TGrammar of \Illuminate\Database\Grammar
     *
     * @param  TGrammar  $grammar
     * @return TGrammar
     */
    public function withTablePrefix(Grammar $grammar)
    {
        $grammar->setTablePrefix($this->tablePrefix);

        return $grammar;
    }
  1. Classes that recursively mixin each other. This was causing a memory exhaustion issue in CI.

This PR can be closed if another PR is merged with these changes. The PR is just here for visibility into the modifications.

@taylorotwell taylorotwell merged commit aa01afe into 11.x Nov 18, 2024
32 checks passed
@taylorotwell taylorotwell deleted the docblocks branch November 18, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants