Test wildcard environments config

[karkowg]

I might be looking at this totally wrong but I believe ProvisioningPlanTest::test_supervisors_are_added_by_wildcard isn't testing anything related to wildcard environments. It just looks like a duplicate of ProvisioningPlanTest::test_supervisors_are_added.

I came by this because each member of my team is using a different APP_ENV and I was looking for a simple way to declare that in the Horizon config without having to list them all. I thought adding a wildcard environment wasn't possible, but it is, only missing documentation. If my assumptions are correct, here's a fix to that test. I've also sent laravel/docs#9706 for documenting the wildcard usage.

Thanks!

[taylorotwell]

Can you add an entirely new test that you think is properly setup?

[karkowg]

Can you add an entirely new test that you think is properly setup?

What would be the benefit of having a new test?

If you diff test_supervisors_are_added and test_supervisors_are_added_by_wildcard, the only difference is the function name.

Don't you think the change is proper in that case? If not, I'm not seeing what that test is doing in its current form.

[driesvints]

@karkowg could you please just add the new test as Taylor requests? It's better to leave the existing tests alone.

[karkowg]

@driesvints yep, no problem. I was just trying to understand what I would have to do differently if adding a new test.